HCK-8608: Oracle. Invalid COMMENT ON statements for Mat. Views in DDL…

… Script tab
hackolade · Oct 31, 2024 · e861565 · e861565
1 parent ceb6544
commit e861565
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/forward_engineering/ddlProvider/ddlProvider.js b/forward_engineering/ddlProvider/ddlProvider.js
@@ -614,6 +614,12 @@ module.exports = (baseProvider, options, app) => {
 			);
 		},
 
+		constructViewObjectForComment({ viewData }) {
+			const object = 'VIEW';
+
+			return viewData.materialized ? 'MATERIALIZED ' + object : object;
+		},
+
 		createView(viewData, dbData, isActivated) {
 			const viewName = getNamePrefixedWithSchemaName(viewData.name, viewData.schemaName);
 
@@ -623,7 +629,7 @@ module.exports = (baseProvider, options, app) => {
 			const comment = viewData.description
 				? '\n' +
 					assignTemplates(templates.comment, {
-						object: 'TABLE',
+						object: this.constructViewObjectForComment({ viewData }),
 						objectName: viewName,
 						comment: wrapComment(viewData.description),
 					}) +

diff --git a/forward_engineering/utils/general.js b/forward_engineering/utils/general.js
@@ -123,9 +123,9 @@ module.exports = _ => {
 			return '/* ' + statement + ' */';
 		} else if (statement.includes('\n')) {
 			return '/*\n' + statement + ' */\n';
-		} else {
-			return inlineComment + ' ' + statement;
 		}
+
+		return inlineComment + ' ' + statement;
 	};
 
 	const wrap = (str, start = "'", end = "'") => {
@@ -134,9 +134,9 @@ module.exports = _ => {
 
 		if (lastChar === start && firstChar === end) {
 			return str;
-		} else {
-			return `${start}${str}${end}`;
 		}
+
+		return `${start}${str}${end}`;
 	};
 
 	const wrapInQuotes = name => `"${name}"`;