HCK-8126, HCK-8127: RE of sequences and synonyms improvements #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DLs of sequences when it takes more than 30s
…only those that are used in the REd tables and views, improved RE of synonyms by removed GET_DDL
bigorn0
reviewed
Sep 26, 2024
|
|
||
| logger.log( | ||
| 'info', | ||
| { message: 'Filter sequences finished', usedSequencesCount: usedSequences?.length || 0 }, |
There was a problem hiding this comment.
I guess this means 'Filtering of sequences used in tables and views finished', at first I saw Getting sequences (which is the title i guess) and it was a bit misleading.
bigorn0
reviewed
Sep 26, 2024
| const sequenceDdlScriptsPromise = mapLimit(namesOfSequences, 50, async sequenceName => { | ||
| try { | ||
| const sequenceDdlScript = await execute( | ||
| `SELECT JSON_OBJECT('ddl' VALUE DBMS_METADATA.GET_DDL('SEQUENCE', '${sequenceName}', '${schema}')) FROM DUAL`, |
There was a problem hiding this comment.
@Vitalii4as FROM DUAL is new (it looks like), was it missing previously or you make sure that Duality views are properly handled explicitly?
bigorn0
approved these changes
Sep 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical details
GET_DDLcall for synonyms, replaed it with LEFT JOIN with ALL_OBJECTS to obtain EDITIONABLEGET_DDLof only used sequences