Feature/hck 4776 bbva sequences definition for oracle alter script #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
serhii-filonenko
commented
Mar 27, 2024
serhii-filonenko
commented
 HCK-4776 [BBVA] Sequences definition for Oracle: Alter script
|
- implemented generation of alter script for schema sequences
|
|
||
| return (container.role?.sequences || []) | ||
| .map((sequence) => ddlProvider.createSchemaSequence({ schemaName, sequence })) | ||
| .map((script) => AlterScriptDto.getInstance([script], true, false)) |
There was a problem hiding this comment.
do we really have to iterate twice here? Can't we just expand the function block of a first map and do whatever we need within a single iteration?
| * @returns {string} | ||
| */ | ||
| createSchemaSequence({ schemaName, sequence }) { | ||
| const usingTryCatchWrapper = shouldUseTryCatchIfNotExistsWrapper(options?.dbVersion); |
There was a problem hiding this comment.
please double-check formatting
chulanovskyi-bs
approved these changes
Mar 27, 2024
…-for-Oracle-Alter-script
chulanovskyi-bs
deleted the
Feature/HCK-4776-BBVA-Sequences-definition-for-Oracle-Alter-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.