fix: invalid regular expressions (#104)

Co-authored-by: chulanovskyi-bs <56116665+chulanovskyi-bs@users.noreply.github.com>
hackolade · Jul 16, 2024 · ff3bec4 · ff3bec4
1 parent dd51fde
commit ff3bec4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/forward_engineering/helpers/commentIfDeactivated.js b/forward_engineering/helpers/commentIfDeactivated.js
@@ -1,5 +1,5 @@
 const BEFORE_DEACTIVATED_STATEMENT = '-- ';
-const REG_FOR_MULTYLINE_COMMENT = /(\n\/\*\n[\s\S]*?\n\s\*\/\n)$|(\n\/\*\n[\s\S]*?\n\s\*\/)$/gi;
+const REG_FOR_MULTYLINE_COMMENT = /(\n\/\*\n[\s\S]*?\n\s\*\/\n)|((\n\/\*\n[\s\S]*?\n\s\*\/)$)/gi;
 
 const commentIfDeactivated = (statement, data, isPartOfLine) => {
 	if (data?.hasOwnProperty('isActivated') && !data.isActivated) {

diff --git a/reverse_engineering/reverseEngineeringService/helpers/reverseTableColumn.js b/reverse_engineering/reverseEngineeringService/helpers/reverseTableColumn.js
@@ -52,8 +52,8 @@ const handleDefault = (typeObject, value) => {
 
 	const validValue = {
 		numeric: Number(value.replace(/(^\(\()|(\)\)$)/g, '')),
-		char: value.replace(/(^\(')$|('\))$/g, ''),
-		xml: value.replace(/(^\(N')$|('\))$/g, ''),
+		char: value.replace(/(^\(')|(('\))$)/g, ''),
+		xml: value.replace(/(^\(N')|(('\))$)/g, ''),
 	}[typeObject.type];
 
 	return { default: validValue !== undefined ? validValue : value };
@@ -102,7 +102,7 @@ const handleColumnProperty = (column, propertyName, value) => {
 		case 'COLUMN_DEFAULT':
 			return handleDefault(handleType(column['DATA_TYPE']), value);
 		case 'IS_NULLABLE':
-			return { required: value === 'NO' ? true : false };
+			return { required: value === 'NO' };
 		case 'DATETIME_PRECISION':
 			return { fractSecPrecision: !isNaN(value) ? value : '' };
 		case 'NUMERIC_SCALE':