Reproduce missing interactions bug #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If my theory is right here, there won't be a screenshot for "Interactive > Demo [white]-clicked" in this build. |
I've found an issue when the first story has interactions and you are using `forceHappoScreenshot`. The check for whether happo is running or not uses `if (currentIndex)` but the first step is 0. I have a fix in mind for this but I want to make sure that we have a way to reproduce first. A small change to how we order components helped make the Interactive - Demo [white] example render first.
trotzig
force-pushed
the
reproduce-missing-interaction
branch
from
e231adc to
cae43d5
Compare
|
Yep, this seems to reproduce the issue. I'll merge this and provide a fix in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue when the first story has interactions and you are using
forceHappoScreenshot. The check for whether happo is running or not usesif (currentIndex)but the first step is 0. I have a fix in mind for this but I want to make sure that we have a way to reproduce first.