Skip to content

Commit

Permalink
Remove unnessesarry actions/core
Browse files Browse the repository at this point in the history
  • Loading branch information
nvuillam committed Sep 11, 2023
1 parent e1e23e5 commit 82f1a9b
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 17 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,17 @@

Note: Can be used with `sfdx plugins:install sfdx-hardis@beta` and docker image `hardisgroupcom/sfdx-hardis@beta`

## [4.5.0] 2023-09-10

- GitHub Integration: Implement automated comments & Quick Deploy on Pull Requests

## [4.4.0] 2023-09-10

- Make sfdx-hardis CI/CD Pipelines **natively compliant with GitHub Actions** , by @legetz
- Create sfdx project: Change defaut first major branch name to `integration` (it was previously `develop`)
- Update default API version to 58.0
- Fix bug when user email is input the first time
- Add info about uninstalling SFDX that has been installed using Windows Installer


## [4.3.2] 2023-09-08

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"author": "NicolasVuillamy @nvuillam",
"bugs": "https://github.com/hardisgroupcom/sfdx-hardis/issues",
"dependencies": {
"@actions/core": "^1.10.0",
"@actions/github": "^5.1.1",
"@adobe/node-fetch-retry": "^1.1.2",
"@amplitude/node": "^1.3.2",
Expand Down
3 changes: 1 addition & 2 deletions src/common/gitProvider/github.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import * as core from "@actions/core";
import * as github from "@actions/github";
import * as c from "chalk";
import { GitProviderRoot } from "./gitProviderRoot";
Expand All @@ -12,7 +11,7 @@ export class GithubProvider extends GitProviderRoot {
constructor() {
super();
const tokenName = process.env.CI_SFDX_HARDIS_GITHUB_TOKEN ? "CI_SFDX_HARDIS_GITHUB_TOKEN" : process.env.PAT ? "PAT" : "GITHUB_TOKEN";
const token = core.getInput(tokenName);
const token = process.env[tokenName];
this.octokit = github.getOctokit(token);
}

Expand Down
13 changes: 0 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@
# yarn lockfile v1


"@actions/core@^1.10.0":
version "1.10.0"
resolved "https://registry.yarnpkg.com/@actions/core/-/core-1.10.0.tgz#44551c3c71163949a2f06e94d9ca2157a0cfac4f"
integrity sha512-2aZDDa3zrrZbP5ZYg159sNoLRb61nQ7awl5pSvIq5Qpj81vwDzdMRKzkWJGJuwVvWpvZKx7vspJALyvaaIQyug==
dependencies:
"@actions/http-client" "^2.0.1"
uuid "^8.3.2"

"@actions/github@^5.1.1":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@actions/github/-/github-5.1.1.tgz#40b9b9e1323a5efcf4ff7dadd33d8ea51651bbcb"
Expand Down Expand Up @@ -7298,11 +7290,6 @@ uuid@^3.3.2, uuid@^3.3.3:
resolved "https://registry.npmjs.org/uuid/-/uuid-3.4.0.tgz"
integrity sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A==

uuid@^8.3.2:
version "8.3.2"
resolved "https://registry.yarnpkg.com/uuid/-/uuid-8.3.2.tgz#80d5b5ced271bb9af6c445f21a1a04c606cefbe2"
integrity sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg==

v8-compile-cache-lib@^3.0.0:
version "3.0.1"
resolved "https://registry.npmjs.org/v8-compile-cache-lib/-/v8-compile-cache-lib-3.0.1.tgz"
Expand Down

0 comments on commit 82f1a9b

Please sign in to comment.