Fix notifications bulletpoints

hardisgroupcom · Nov 14, 2023 · f1aed9c · f1aed9c
1 parent 57bac7d
commit f1aed9c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ Note: Can be used with `sfdx plugins:install sfdx-hardis@beta` and docker image
 
 - New command **sfdx hardis:org:diagnose:audittrail** to detect suspect actions in major orgs
   - Run by default in org monitoring
+- Fix notifications bulletpoints
 
 ## [4.11.0] 2023-11-14
 

diff --git a/src/commands/hardis/org/diagnose/audittrail.ts b/src/commands/hardis/org/diagnose/audittrail.ts
@@ -195,12 +195,12 @@ export default class DiagnoseAuditTrail extends SfdxCommand {
       let notifDetailText = ``
       notifDetailText += "Related users:\n";
       for (const user of suspectUsers) {
-        notifDetailText += `- ${user}\n`;
+        notifDetailText += `* ${user}\n`;
       }
       notifDetailText += "\n"
       notifDetailText += "Related actions:\n";
       for (const action of suspectActions) {
-        notifDetailText +=`- ${action}`;
+        notifDetailText +=`* ${action}\n`;
       }
       notifDetailText += "\n"
       notifDetailText += "_See details in job artifacts_"

diff --git a/src/commands/hardis/org/diagnose/legacyapi.ts b/src/commands/hardis/org/diagnose/legacyapi.ts
@@ -222,13 +222,13 @@ See article below
       uxLog(this, c.grey(c.bold("End of support API version calls:") + JSON.stringify(allEndOfSupportApiCalls, null, 2)));
     }
 
-    const notifDetailText = `- Dead API version calls found in logs           : ${allDeadApiCalls.length} (${this.legacyApiDescriptors[0].deprecationRelease})
-    - Deprecated API version calls found in logs     : ${allSoonDeprecatedApiCalls.length} (${this.legacyApiDescriptors[1].deprecationRelease})
-    - End of support API version calls found in logs : ${allEndOfSupportApiCalls.length} (${this.legacyApiDescriptors[2].deprecationRelease})
+    const notifDetailText = `* Dead API version calls found in logs           : ${allDeadApiCalls.length} (${this.legacyApiDescriptors[0].deprecationRelease})
+    * Deprecated API version calls found in logs     : ${allSoonDeprecatedApiCalls.length} (${this.legacyApiDescriptors[1].deprecationRelease})
+    * End of support API version calls found in logs : ${allEndOfSupportApiCalls.length} (${this.legacyApiDescriptors[2].deprecationRelease})
     
     See article to solve issue before it's too late:
-    - EN: https://nicolas.vuillamy.fr/handle-salesforce-api-versions-deprecation-like-a-pro-335065f52238
-    - FR: https://leblog.hardis-group.com/portfolio/versions-dapi-salesforce-decommissionnees-que-faire/`;
+    * EN: https://nicolas.vuillamy.fr/handle-salesforce-api-versions-deprecation-like-a-pro-335065f52238
+    * FR: https://leblog.hardis-group.com/portfolio/versions-dapi-salesforce-decommissionnees-que-faire/`;
 
     // Manage notifications
     if (allErrors.length > 0) {

diff --git a/src/commands/hardis/org/monitor/backup.ts b/src/commands/hardis/org/monitor/backup.ts
@@ -122,7 +122,7 @@ export default class MonitorBackup extends SfdxCommand {
       }
       const attachments: MessageAttachment[] = [
         {
-          text: diffFiles.join("\n "),
+          text: diffFiles.map(diffLine => `* ${diffLine}`).join("\n"),
         },
       ];
       NotifProvider.postNotifications({