Annotate query results with QuerySet instead of BaseManager #3668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3659, we discussed finding a better type annotation for Django ORM querysets than
BaseManager
.I had the impression we'd need to add an external dependency for this, but it turns out we can in fact do
QuerySet[LinkUser]
and so on. Moreover, django-stubs seems to have its own nuances (and only supports Mypy?); seems not worth bringing in at present.This branch swaps
QuerySet
type hints in for all our existingBaseManager
s. There should be zero impact on Perma functionality, as this is purely a dev-side change.