Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maintainers as codeowners to all files #556

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

PavelSBorisov
Copy link
Member

Description:
Update CODEOWNERS to provide maintainers ownership of all files in their repos

Related issue(s):

Fixes #550

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: PavelSBorisov <pavel.s.borisov@gmail.com>
@PavelSBorisov PavelSBorisov self-assigned this Dec 12, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners December 12, 2024 13:19
@PavelSBorisov PavelSBorisov linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link

Unit Test Results

35 tests  ±0   35 ✅ ±0   10m 25s ⏱️ -49s
21 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6e091ab. ± Comparison against base commit 4da2182.

Copy link

E2E Test Results

4 tests  ±0   4 ✅ ±0   46s ⏱️ -6s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6e091ab. ± Comparison against base commit 4da2182.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4da2182) 1662 1094 65.82%
Head commit (6e091ab) 1662 (+0) 1094 (+0) 65.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#556) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.51%. Comparing base (4da2182) to head (6e091ab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   65.51%   65.51%           
=======================================
  Files          60       60           
  Lines        1914     1914           
  Branches      291      289    -2     
=======================================
  Hits         1254     1254           
- Misses        624      659   +35     
+ Partials       36        1   -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@PavelSBorisov PavelSBorisov merged commit 6d35010 into main Dec 12, 2024
18 checks passed
@PavelSBorisov PavelSBorisov deleted the 550-add-repo-maintainers-to-codeowners-file branch December 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Repo Maintainers to CODEOWNERS file
2 participants