support ingoring comments

henryluki · May 19, 2017 · fff53b1 · fff53b1
1 parent 41964fe
commit fff53b1
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 1 deletion.
diff --git a/dist/htmlParser.es6.js b/dist/htmlParser.es6.js
@@ -136,6 +136,11 @@ function tokenize(html) {
   const maxTime = Date.now() + 1000;
 
   while (string) {
+    if (string.indexOf("<!--") === 0) {
+      const lastIndex = string.indexOf("-->") + 3;
+      string = string.substring(lastIndex);
+      continue
+    }
     if (string.indexOf("</") === 0) {
       const match = string.match(ENDTAG_REX);
       if (!match) continue

diff --git a/dist/htmlParser.js b/dist/htmlParser.js
@@ -220,6 +220,11 @@ function tokenize(html) {
   var maxTime = Date.now() + 1000;
 
   while (string) {
+    if (string.indexOf("<!--") === 0) {
+      var lastIndex = string.indexOf("-->") + 3;
+      string = string.substring(lastIndex);
+      continue;
+    }
     if (string.indexOf("</") === 0) {
       var match = string.match(ENDTAG_REX);
       if (!match) continue;

diff --git a/dist/htmlParser.min.js b/dist/htmlParser.min.js
diff --git a/src/tokenizer/index.js b/src/tokenizer/index.js
@@ -8,6 +8,11 @@ export function tokenize(html) {
   const maxTime = Date.now() + 1000
 
   while (string) {
+    if (string.indexOf("<!--") === 0) {
+      const lastIndex = string.indexOf("-->") + 3
+      string = string.substring(lastIndex)
+      continue
+    }
     if (string.indexOf("</") === 0) {
       const match = string.match(ENDTAG_REX)
       if (!match) continue

diff --git a/test/index.js b/test/index.js
@@ -38,6 +38,12 @@ test('should pass the empty tag case', t=> {
   t.deepEqual(div.children[0], br)
 })
 
+test('should pass the comment case', t=> {
+  const html = "<div><!-- hahha--></div>"
+  const div = htmlParser(html).children[0]
+  t.deepEqual(div.children.length, 0)
+})
+
 test('should pass the nested element case', t=> {
   const html = "<div>a<p>b<span>c</span></p></div>"
   const tree = {