fs.mkdir return strign when success

different from documentaion
hjyssg · Dec 13, 2020 · 497ab06 · 497ab06
1 parent 2225f15
commit 497ab06
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/server/imageMagickHelp.js b/src/server/imageMagickHelp.js
@@ -30,7 +30,7 @@ img_convert_min_threshold *= 1024 * 1024;
 
 
 function logFail(filePath, e) {
-    logger.error("[imageMagickHelp]]", filePath, e);
+    logger.error("[imageMagickHelp]", filePath, e);
 }
 
 global._has_magick_ = true;
@@ -90,8 +90,8 @@ module.exports.minifyOneFile = async function (filePath) {
         //mkdir for output
         if (!(await isExist(minifyOutputPath))) {
             const mdkirErr = await pfs.mkdir(minifyOutputPath, { recursive: true });
-            if (mdkirErr) {
-                logFail(filePath, "cannot create output folder");
+            if (mdkirErr instanceof Error) {
+                logFail(minifyOutputPath, "cannot create output folder");
                 return;
             }
         }

diff --git a/src/server/index.js b/src/server/index.js
@@ -93,7 +93,7 @@ async function mkdir(path, quiet) {
     if (!(await isExist(path))) {
         try {
             const err = await pfs.mkdir(path, { recursive: true });
-            if (err) {
+            if (err instanceof Error) {
                 throw err;
             }
         } catch (err) {

diff --git a/src/server/routes/moveOrDelete.js b/src/server/routes/moveOrDelete.js
@@ -58,9 +58,11 @@ router.post('/api/moveFile', async (req, res) => {
         let err;
         if (!(await isExist(dest))) {
             err = await pfs.mkdir(dest, { recursive: true });
+            if (err instanceof Error) {
+             throw "fail to create dest folder"; 
+            }
         }
 
-        if (err) { throw "fail to create dest folder"; }
 
         const cmdStr = isWindows() ? "move" : "mv";
         const { stdout, stderr } = await execa(cmdStr, [src, dest]);

diff --git a/src/tools/cleanCache.js b/src/tools/cleanCache.js
@@ -30,7 +30,7 @@ function cleanCache(cachePath, config) {
     counter = 0
     if (!fs.existsSync(cachePath)) {
         err = fs.mkdir(cachePath, (err) => {
-            if (err) {
+            if (err instanceof Error) {
                 throw err;
             }
         });