Revert rerender fix

hmans · Sep 17, 2022 · 5c8de24 · 5c8de24
1 parent ed5c647
commit 5c8de24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/flat-boxes-explain.md b/.changeset/flat-boxes-explain.md
@@ -0,0 +1,5 @@
+---
+"statery": patch
+---
+
+Revert the previous fix for potentially infinite rerenders -- turns out it was a user issue (the user being me!), and the fix would actually cause bigger problems elsewhere.
diff --git a/src/index.ts b/src/index.ts
@@ -181,7 +181,7 @@ export const useStore = <T extends IState>(store: Store<T>): T => {
 
     subscribedProps.forEach((prop) => {
       if (initialState[prop] !== store.state[prop]) {
-        setVersion(v + 1)
+        setVersion((v) => v + 1)
         return
       }
     })
@@ -193,14 +193,14 @@ export const useStore = <T extends IState>(store: Store<T>): T => {
       /* If there is at least one prop being updated that we're interested in,
          bump our local version. */
       if (Object.keys(updates).find((prop) => subscribedProps.has(prop))) {
-        setVersion(v + 1)
+        setVersion((v) => v + 1)
       }
     }
 
     /* Mount & unmount the listener */
     store.subscribe(listener)
     return () => void store.unsubscribe(listener)
-  }, [store, v])
+  }, [store])
 
   return new Proxy<Record<any, any>>(
     {},