-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web tokens auth #21
Merged
Merged
Web tokens auth #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hmunish Do not merge this branch until I finish the full implementation of the auth user |
…et the "Bearer token"
This was
linked to
issues
Oct 29, 2023
hmunish
approved these changes
Oct 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aradradev, great job implementing user authentication & endpoints for cars. It's time to merge it.
🟢 User authentication working fine.
🟢 Cars API working fine.
🟢 Linters are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this milestone we have implemented the following features:
Created get post and delete request for the user
Created Cars Controller::API
Generated and added the features for the API
Tested the API on Postman
Authentication for user API:: http://localhost:3000/api/v1/login/ Explanation: This API will make sure that a user logs in to access the page, and it will give secure web tokens and this token can be used to make requests for cars and registrations.
token: Authorization type: Bearer.
Users API:: http://localhost:3000/api/v1/users/ Explanation: how this API could be used to make a post request and get a new user it uses the last web token to create a new user.
Cars API:: http://localhost:3000/api/v1/users/user_id/cars :: API::In-progress...
`
Please review the API above and make sure that we can make GET, POST, and DELETE requests.