-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme.md #29
Add readme.md #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project Status: CHANGES REQUIRED ♻️
Hi @FaranoshAmini ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🔥
Required Changes ♻️
Check the comments under the review.
You can also consider:
- N/A
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
README.md
Outdated
|
||
* Deployment instructions | ||
## 🚀 Frontend App <a name="frontend"></a> | ||
- [Click here to navigate to the Frontend ]() | ||
|
||
* ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add the link pointing to the Frontend Project, What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STATUS: APPROVED 🟢
Hi @FaranoshAmini ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
(Highlights) Good Points: 👍
- You documented your work professionally. ✔
- Great job implementing the requested changes. 🎉 🎉 🎉 ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
In this pull request, I have implemented the following changes :