Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme.md #29

Merged
merged 6 commits into from
Nov 4, 2023
Merged

Add readme.md #29

merged 6 commits into from
Nov 4, 2023

Conversation

FaranoshAmini
Copy link
Collaborator

In this pull request, I have implemented the following changes :

  • Add professional Readme.md

Copy link
Collaborator

@aradradev aradradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Status: CHANGES REQUIRED ♻️

Hi @FaranoshAmini ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights 🔥

Required Changes ♻️

Check the comments under the review.

You can also consider:

  • N/A

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

README.md Outdated
Comment on lines 45 to 24

* Deployment instructions
## 🚀 Frontend App <a name="frontend"></a>
- [Click here to navigate to the Frontend ]()

* ...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add the link pointing to the Frontend Project, What do you think?

@aradradev aradradev self-requested a review November 3, 2023 21:21
Copy link
Collaborator

@aradradev aradradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢

Hi @FaranoshAmini ,

Congratulations!GIF

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Great job implementing the requested changes. 🎉 🎉 🎉 ✔

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

@hmunish hmunish merged commit b7db1df into dev Nov 4, 2023
3 checks passed
@hmunish hmunish linked an issue Nov 4, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.5pt] - Add Backend readme.md
3 participants