Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Final Version #10

Merged
merged 15 commits into from
Nov 3, 2023
Merged

Create Final Version #10

merged 15 commits into from
Nov 3, 2023

Conversation

FaranoshAmini
Copy link
Collaborator

In this pull request, I have implemented the following changes :

  • Add sidebar icons.

@FaranoshAmini FaranoshAmini linked an issue Nov 3, 2023 that may be closed by this pull request
5 tasks
@hmunish hmunish requested a review from aradradev November 3, 2023 15:31
Copy link
Collaborator

@aradradev aradradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🥇 💯

success

Hey @FaranoshAmini , @hmunish 👋

Great work on implementing the final touch. Your project is complete. 😊
There is nothing else to say about your project. 👍

Highlights 🥇

✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Gitflow
✔️ Following Requirements
✔️ Great work on making the icons and the logout button as expected 💚
✔️ Great work on making this project collaboratively 🤝

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

@hmunish hmunish merged commit 9f4d4a2 into dev Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] - Create Final Version - Munish
3 participants