Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix components & slices errors #14

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix components & slices errors #14

merged 4 commits into from
Nov 6, 2023

Conversation

hmunish
Copy link
Owner

@hmunish hmunish commented Nov 6, 2023 •
edited
Loading

Tasks completed:-

  • Updated component to ES6 standards
  • Fix car details page
  • Fix add car issue

@hmunish hmunish requested a review from aradradev November 6, 2023 08:24
aradradev
aradradev approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@aradradev aradradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hmunish ,

Thanks for making the changes! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight

  • Correct use of GitFlow ✔️
  • Descriptive commit messages ✔️
  • Slide cars are working fine ✔️
  • Delete Car is working ✔️
    Image

Cheers and Happy coding!👏👏👏

@aradradev aradradev merged commit ee5aea4 into dev Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradradev aradradev aradradev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmunish @aradradev