Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework enigma2 tests #135475

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

autinerd
Copy link
Contributor

Proposed change

This reworks the Enigma2 tests, which has then 100% coverage :)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@autinerd
Copy link
Contributor Author

The eheimdigital change was by accident 🙈

tests/components/enigma2/conftest.py Outdated Show resolved Hide resolved
tests/components/enigma2/conftest.py Outdated Show resolved Hide resolved
tests/components/enigma2/conftest.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_config_flow.py Show resolved Hide resolved
tests/components/enigma2/test_media_player.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_media_player.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_media_player.py Outdated Show resolved Hide resolved
tests/components/enigma2/test_media_player.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 13, 2025 11:08
@autinerd autinerd marked this pull request as ready for review January 14, 2025 18:27
@home-assistant home-assistant bot requested a review from joostlek January 14, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants