Fix spelling of "Set up …" and replace duplicate with reference #135512
Conversation
- Replace "Setup Velux" with "Set up Velux" for proper grammar. - Replace the second occurrence with reference of the first.
home-assistant
bot
added
bugfix
cla-signed
integration: velux
small-pr
|
Hey there @Julius2342, @DeerMaximum, @pawlizio, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -2,14 +2,14 @@ | |||
| "config": { | |||
| "step": { | |||
| "user": { | |||
| "title": "Setup Velux", | |||
| "title": "Set up Velux", | |||
There was a problem hiding this comment.
Hmmm this is kinda already implied. This has been missed during review probably.
I think this should be removed.
There was a problem hiding this comment.
Sorry, I'm afraid I don't understand what you mean with "implied".
Correct grammar is either "Velux setup" or "Set up Velux", isn't it?
There was a problem hiding this comment.
This shows up in the UI at the moment:
| "data": { | ||
| "host": "[%key:common::config_flow::data::host%]", | ||
| "password": "[%key:common::config_flow::data::password%]" | ||
| } | ||
| }, | ||
| "discovery_confirm": { | ||
| "title": "Setup Velux", | ||
| "title": "[%key:component::velux::config::step::user::title%]", |
There was a problem hiding this comment.
This string was just added for the auto-discovery flow, it's not in the shipped release, yet.
Anyhow I wouldn't be able to produce a screenshot like the one above without a Velux Gateway here.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: