Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused noqas #135583

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Remove unused noqas #135583

wants to merge 1 commit into from

Conversation

joostlek
Copy link
Member

Proposed change

Remove unused noqas

Early spring cleaning 🪣 🌸

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member Author

joostlek commented Jan 14, 2025

This also leaves me the question, why don't we enable RUF100 by default?

cc @cdce8p

@cdce8p
Copy link
Member

cdce8p commented Jan 14, 2025

This also leaves me the question, why don't we enable RUF100 by default?

Seems it was added and commented out in #113616 to mirror what we do for pylint. Tbh. I'm not sure how stable the RUF100 rule itself is. At least for pylint I know that it caused issues from time to time which is why we didn't enable it. In the end one additional ignore doesn't hurt anyone but failing CI will be annoying.

I usually cleanup pylint disable comments when I update the pylint version. Maybe that's also an option for ruff updates? Of course it requires some manual labour but then again a ruff run is quite fast.

@joostlek
Copy link
Member Author

Because i do see some people adding new integrations where they add extra noqas to some things and then don't remove them, when they maybe can

@cdce8p
Copy link
Member

cdce8p commented Jan 14, 2025

Because i do see some people adding new integrations where they add extra noqas to some things and then don't remove them, when they maybe can

We can try it for ruff and see how it goes. If it doesn't work, we can always revert it later if necessary 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants