Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete re-work of OpenHardwareMonitor integration #135605

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

LazyTarget
Copy link

Breaking change

Proposed change

Re-worked integration to allow for Config Flow and to group the generated entities into respective Devices

New features:

  • Allows for Config Flow for setting up the integration
  • The generated entities can now be grouped into an appropriate Device or Devices
  • Updated standards to allow to upgrade this integration from it's "Legacy" status

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

- Added config flow for when adding integration
- Grouping the entities into relevant Devices
- Refactoring to new 'async_setup_entry' initialization
@LazyTarget
Copy link
Author

This is my first PR into Home Assistant. Please let me know if I need to add or modify something!

Also I am open to being a code mainter for this OpenHardwareMonitor integration, since I have spent quite some time with the code and am confident on how it works (same with the actual Server application).

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is one thing that was blocking the Open Hardware Monitor integration from being migrated to the config flow, and that is that it should get a library for requesting the data from the application. Once this is added, the config flow can be added and this can be set up via the UI.

If you need help with that, feel free to reach out on discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants