Add support for Bot in SwitchBot Cloud #135606
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
mckbrmn
force-pushed
the
switchbot-cloud-bot
branch
2 times, most recently
from
c8b2139 to
d67d159
Compare
| await hass.config_entries.async_forward_entry_setups(config, PLATFORMS) | ||
| await gather( | ||
| *[coordinator.async_refresh() for coordinator in coordinators_by_id.values()] | ||
| ) | ||
| await hass.config_entries.async_forward_entry_setups(config, PLATFORMS) |
There was a problem hiding this comment.
This change is correct, but we should do this in a separate PR
| if "Bot" in device.device_type: | ||
| if ( | ||
| coordinator.data is not None | ||
| and coordinator.data.get("deviceMode") == "pressMode" | ||
| ): | ||
| # pressMode Bots are handled by the Button platform | ||
| return None | ||
| return SwitchBotCloudSwitch(api, device, coordinator) |
There was a problem hiding this comment.
Why is this here? The switch platform doesn't create things for the Bot right?
There was a problem hiding this comment.
Bots can be configured to behaved in two different modes:
- in
switchMode, there are two actions,on(the little arm goes out and stays out) andoff(the little arm goes back in and stays in) - in
pressMode, there is only one action: the little arm comes out and immediately goes back in.
(there's a third mode customizeMode that has the same actions as switchMode but the behavior is customizable).
I've mapped the switchMode/customizeMode to the switch platform and the pressMode to the button platform.
| @@ -111,6 +113,10 @@ def make_device_data( | |||
| devices_data.locks.append( | |||
| prepare_device(hass, api, device, coordinators_by_id) | |||
| ) | |||
| if isinstance(device, Device) and device.device_type in ["Bot"]: | |||
| devices_data.buttons.append( | |||
There was a problem hiding this comment.
buttons is never used. the button platform is using switches instead. is this needed?
There was a problem hiding this comment.
It was a mistake on my part, I've updated the button platform code to use buttons
mckbrmn
force-pushed
the
switchbot-cloud-bot
branch
from
d67d159 to
1575c00
Compare
mckbrmn
force-pushed
the
switchbot-cloud-bot
branch
from
1575c00 to
949d308
Compare
Proposed change
Adds support for SwitchBot Bots (in SwitchBot Cloud) both as switches for Bots in
switchModeandcustomizeMode, as well as buttons for Bots inpressMode.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: