Prevent pull-to-refresh from triggering while scrolling in a nested scrollable element on the page #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #294
This prevents pull-to-refresh from being triggered when (potentially) nested scrolling within an element on the page that is using
overflow-y: scroll
oroverflow-y: auto
. To address this, the following item were added:TurboWebView
that the currently touched element is scrollable.TurboWebView
.TurboSwipeRefreshLayout
checks to see if its scrollable child can scroll up, check the state of theTurboWebView
if a scrollable element is currently being touched.