Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark]: llama add tokens metrics #5939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeroorhero
Copy link

When benchmarking a LLM, token/s is also an
important metric, so this metric is added to the
llama benchmark.

When benchmarking a LLM, token/s is also an
important metric, so this metric is added to the
llama benchmark.

Signed-off-by: Changqi Lu <luchangqi.123@bytedance.com>
@zeroorhero zeroorhero requested a review from a team as a code owner July 25, 2024 01:12
@zeroorhero
Copy link
Author

Ping! Could you give me some advice?

)
self.coordinator.print_on_master(
f"Throughput: {avg_throughput:.2f} samples/sec, TFLOPS per GPU by Megatron: {avg_tflops_per_gpu_megatron:.2f}, TFLOPS per GPU: {avg_tflops_per_gpu:.2f}"
f"Throughput_Samples: {avg_throughput_samples:.2f} samples/sec, Throughput_Tokens: {avg_throughput_tokens:.2f} samples/sec, TFLOPS per GPU by Megatron: {avg_tflops_per_gpu_megatron:.2f}, TFLOPS per GPU: {avg_tflops_per_gpu:.2f}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{avg_throughput_tokens:.2f} samples/sec seems to be a typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants