Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hash negotiation and force sha-256 #2645

Closed
wants to merge 0 commits into from
Closed

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Oct 9, 2023

This removes the hashes negotiation and changes the Available-Dictionary request header to explicitly use sha-256 as discussed in #2631. If sha-256 becomes insufficient, the hash negotiation can then be added (or different mechanisms can be used).

Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, though I would also add a paragraph somewhere about what you might do to upgrade SHA-256 if there was ever cause to do so (and maybe why that is unlikely, as we are not relying on any of the properties of the function that are security-relevant).

@pmeenan
Copy link
Contributor Author

pmeenan commented Oct 10, 2023

WFM, though I would also add a paragraph somewhere about what you might do to upgrade SHA-256 if there was ever cause to do so (and maybe why that is unlikely, as we are not relying on any of the properties of the function that are security-relevant).

Thanks. I added a paragraph to the security section about what the hash is used for and what it would look like if it was decided that SHA-256 needed to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants