Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade outlines to 0.1.1 #2690

Closed
wants to merge 3 commits into from
Closed

Upgrade outlines to 0.1.1 #2690

wants to merge 3 commits into from

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Oct 25, 2024

What does this PR do?

CI run PR
Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil mentioned this pull request Oct 25, 2024
4 tasks
@Narsil Narsil requested a review from drbh October 25, 2024 09:04
* Upgrade outlines to 0.1.1

* Update for new API

* Check if allowed tokens is None

---------

Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
@Narsil Narsil closed this Oct 28, 2024
@aW3st
Copy link
Contributor

aW3st commented Oct 28, 2024

@Narsil can we re-open and merge this PR? #2694 merged into this branch.

@dszeto
Copy link

dszeto commented Oct 29, 2024

Hello, super excited to see this upgrade because my use case requires context-free grammar (CFG) support that was introduced in 0.1.0. Is there any plan to support CFG from the generation API? This will allow us to migrate our inference infra to TGI. Happy to help if it's a good idea. @Narsil @aW3st

@aW3st
Copy link
Contributor

aW3st commented Oct 30, 2024

@Narsil can we re-open and merge this PR? #2694 merged into this branch.

Bumping this so it doesn't get lost. Main branch is still on the old outlines version.

@aW3st
Copy link
Contributor

aW3st commented Nov 1, 2024

@Narsil can we re-open and merge this PR? #2694 merged into this branch.

Bumping this so it doesn't get lost. Main branch is still on the old outlines version.

@drbh perhaps you can help us out here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants