Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Rust toolchain, clippy, and minor ci changes #1311

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Adjust Rust toolchain, clippy, and minor ci changes #1311

merged 5 commits into from
Dec 11, 2024

Conversation

JamesKEbert
Copy link
Contributor

@JamesKEbert JamesKEbert commented Dec 11, 2024 •
edited
Loading

Changes

  • Sets toolchain to stable 1.79 (no longer using nightly in some places too)
    • Removed unstable feature style formatting rules (only available on nightly)
  • Defines recommendations to contributors for clippy and formatting
  • Removes codecov
  • updates ci to run just clippy to match what developers are instructed to do.
  • minor style formatting fixes from running just fmt

@JamesKEbert
chore: adjust toolchain, clippy, and ci
a5cca8d 
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
@JamesKEbert
merge main
41a249e 
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
@JamesKEbert
chore: adjust clippy instructions
459bc7d 
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
@JamesKEbert
chore: adjust justfile, update clippy ci tasks
3acd25b 
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
@JamesKEbert
chore: remove unstable feature code formatting rules
600839f 
Signed-off-by: James Ebert <jamesebert.k@gmail.com>
gmulhearn
gmulhearn approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@gmulhearn gmulhearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thank you!

@JamesKEbert JamesKEbert merged commit 62ce000 into hyperledger:main Dec 11, 2024
15 checks passed
@JamesKEbert JamesKEbert deleted the chore/adjustClippy branch December 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmulhearn gmulhearn gmulhearn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesKEbert @gmulhearn