Add pull but don't deploy, notification system #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
put config.json in its own folder so it can be easily exposed in a bind mount update dockerfile - docker secret support - take advantage of image layer caching add dockerignore file to reduce image size
Add custom logger for better log formatting index.js -remove unused `Package` variable -consistent quotes
index.js -remove configuration code and move to lib/config lib/config -add support for reading docker secrets -sanity check config.json
Add support for optional credentials
move docker api code out of index.js into lib/docker
Add options to be able to pull updated images without automatically deploying them
Add optional feature to log stderr and stdout from docker calls
IME, docker service update doesn't reliably pull the latest the latest image. Add workaround.
Added functionality to be able to send success/fail notifications via a notfication plugin system. Added Mailgun email plugin
postinstall script will run NPM install against the plugins folder
from `COPY . .` the `config` directory and the `config.json` file already exist
Previously forgot to --save
Add: HTTPS Server Add: Get config.json from Github Improve: add more error guards, logging Fix: issues installing npm packages in plugins Fix: don't attempt docker login if credentials weren't provided
|
Wow, thanks for these! I've been away from the keyboard for a week but will check out all the changes this week! |
fix configFilePath add CONFIG_DIR & CONFIG_FILE to initLocalDev remove CONFIG_PATH from initLocalDev
|
Hey there! I spoke to soon and turns I'm going to be out of town again until next week, will follow up Tuesday or Wednesday. Thanks! :-) |
|
Okay, I lied about that it seems - am going to rustle up some tests then merge this! |
|
Are you still planning on merging? |
|
Hi again. Oops, I forgot about this as was looking other projects. 🤦♂️ I'll try and get this merged in when I get a minute to take a look. |
Why: * current setup does not allow for dynamically setting what config to read via Dockerfile directly or via use of env variables in docker-compose file * given multiple instances/environemts, need to be able to use same Dockerfile to set what config to read dyamically This change address the need by: * introducing the use of ARG values in Dockerfile to set value of CONFIG env variable at image build time
|
@iaincollins I think the 3000 additions probably overloaded you :P They seem like good additions for a more robust project. Could we review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the huge PR. I added some features that I needed and made a few small improvements.