Skip to content

Commit

Permalink
Merge pull request #84 from ibi-group/upgrade-node-version
Browse files Browse the repository at this point in the history
Correctly specify node 18 version
  • Loading branch information
miles-grant-ibigroup authored Jun 19, 2023
2 parents efc0fe7 + d8c80a5 commit 9cce924
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 17.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 17.x
node-version: 18.x
- name: Install npm packages using cache
uses: bahmutov/npm-install@v1
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Use Node.js 14.x
- name: Use Node.js 18.x
uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: 18.x
- name: Install npm packages using cache
uses: bahmutov/npm-install@v1
with:
Expand Down
6 changes: 3 additions & 3 deletions __tests__/e2e/e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ describe('end-to-end tests', () => {
password: process.env.E2E_PASSWORD,
username: process.env.E2E_USERNAME_API
})
await page.keyboard.press('Enter')
} catch (error) {
console.warn(error)
console.warn(
'You may have forgotten to set E2E_PASSWORD or E2E_USERNAME_API environment variables'
)
}
await page.click('button[type="submit"]')

await page.waitForNavigation({ waitUntil: 'networkidle2' })

Expand Down Expand Up @@ -84,13 +84,13 @@ describe('end-to-end tests', () => {
password: process.env.E2E_PASSWORD,
username: E2E_USERNAME
})
await page.keyboard.press('Enter')
} catch (error) {
console.warn(error)
console.warn(
'You may have forgotten to set E2E_PASSWORD or E2E_USERNAME environment variables'
)
}
await page.click('button[type="submit"]')

await page.waitForNavigation({ waitUntil: 'networkidle2' })

Expand Down Expand Up @@ -170,13 +170,13 @@ describe('end-to-end tests', () => {
password: process.env.E2E_PASSWORD,
username: NEW_CDP_USERNAME
})
await page.keyboard.press('Enter')
} catch (error) {
console.warn(error)
console.warn(
'You may have forgotten to set E2E_PASSWORD or E2E_NEW_USERNAME_1 environment variables'
)
}
await page.click('button[type="submit"]')

await page.waitForNavigation({ waitUntil: 'networkidle2' })

Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
"name": "otp-admin-ui",
"version": "1.0.0",
"main": "index.js",
"engines": {
"node": ">=14.x"
},
"engines": { "node": "18.x" },
"license": "MIT",
"scripts": {
"build": "next build",
Expand Down

1 comment on commit 9cce924

@vercel
Copy link

@vercel vercel bot commented on 9cce924 Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

otp-admin-ui – ./

otp-admin-ui-ibi-group.vercel.app
otp-admin-ui-git-dev-ibi-group.vercel.app
otp-admin-ui.vercel.app

Please sign in to comment.