Skip to content

Commit

Permalink
fix: update binaries for windows and vscode
Browse files Browse the repository at this point in the history
  • Loading branch information
bimalkjha committed Sep 6, 2022
1 parent 6741b7f commit c7dfd00
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 30 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ ibm_db: 2.8.1

- For Node.js >= V15.x on RHEL and RHEL 8.x, GCC v8.2.1 is required.

- The latest node.js version using which `ibm_db` is tested: 18.6.0
- The latest node.js version using which `ibm_db` is tested: 18.8.0

## Install

Expand Down
Binary file modified build.zip
Binary file not shown.
28 changes: 8 additions & 20 deletions installer/driverInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var platform = os.platform();
var arch = os.arch();

var vscode_build = false;
var electron_version = '18.3.5';
var electron_version = '19.0.12';
var downloadProgress = 0;
var silentInstallation = false;

Expand Down Expand Up @@ -611,9 +611,9 @@ var install_node_ibm_db = function(file_url) {
var ODBC_BINDINGS_V11 = 'build\/Release\/odbc_bindings.node.11.15.0';
var ODBC_BINDINGS_V12 = 'build\/Release\/odbc_bindings.node.12.22.12';
var ODBC_BINDINGS_V13 = 'build\/Release\/odbc_bindings.node.13.14.0';
var ODBC_BINDINGS_V14 = 'build\/Release\/odbc_bindings.node.14.19.3';
var ODBC_BINDINGS_V14 = 'build\/Release\/odbc_bindings.node.14.20.0';
var ODBC_BINDINGS_V15 = 'build\/Release\/odbc_bindings.node.15.14.0';
var ODBC_BINDINGS_V16 = 'build\/Release\/odbc_bindings.node.16.15.1';
var ODBC_BINDINGS_V16 = 'build\/Release\/odbc_bindings.node.16.17.0';
var ODBC_BINDINGS_V17 = 'build\/Release\/odbc_bindings.node.17.9.1';

// Windows add-on binary for node.js v0.10.x, v0.12.7, 4.x, 6.x, 7.x and 8.x has been discontinued.
Expand Down Expand Up @@ -834,27 +834,15 @@ function findElectronVersion() {
var codeOut = execSync('code --version').toString();
vscodeVer = parseFloat(codeOut.split('\n')[0]);
if(!isNaN(vscodeVer)) {
if (vscodeVer >= 1.69){
if (vscodeVer >= 1.71){
electron_version = "19.0.12";
}
else if (vscodeVer >= 1.69){
electron_version = "18.3.5";
}
else if (vscodeVer >= 1.67){
else {// vscode version older than 1.67 not supported
electron_version = "17.4.1";
}
else if (vscodeVer >= 1.66){
electron_version = "17.2.0";
}
else if (vscodeVer >= 1.63){
electron_version = "13.5.2";
}
else if (vscodeVer >= 1.56){
electron_version = "12.0.4";
}
else if (vscodeVer >= 1.53){
electron_version = "11.2.1";
}
else {// vscode version older than 1.53 not supported
electron_version = "7.1.11"; // old binary, not getting updated.
}
printMsg("Detected VSCode version" + vscodeVer +
", will use Electron version " + electron_version);
}
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"fs-extra": "^8.1.0",
"fstream": "^1.0.12",
"lodash": "^4.17.21",
"nan": "^2.15.0",
"nan": "^2.16.0",
"q": "^1.5.1",
"targz": "^1.0.1",
"unzipper": "^0.10.11"
Expand Down

0 comments on commit c7dfd00

Please sign in to comment.