-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for subtitles from multiple languages #262
Conversation
Could use a preliminary review since I'm not sure if these changes will negatively effect other parts of the system or future plans, thanks! |
looks mostly ok to me. I'm assuming you've tried it out with clipping and it gives expected results? |
was working for me, will need to verify after making the changes you recommended |
|
@iejMac Think the necessary changes are done and was able to test that I'm getting what is expect. |
sorry about the lint stuff, but think I finally got what I could resolved. However, pylint complains about |
4b09b98
to
834a20e
Compare
thanks for the PR @sramshetty ! |
Feature
Aim is to capture all requested subtitles with the same clip segment, i.e. subtitles share the same clip time segment.
Notes:
Additionally, noticed that
yt-dlp
doesn't like playlist links and causes issues since "requested_subtitles" and other keys are not present; however the metadata returned ininfo_dict
can be used to parse all subtitles from full list of videos in playlist. Maybe making that note for video set curation could help others if I didn't miss a preexisting warning.