-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bay for Wizard castle #7431
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ihhub, I left two code style related comments. Could you please check if theу make sense when you have time.
@golden-lining, well done!
Kudos, SonarCloud Quality Gate passed! |
Hi, @ihhub ! |
Hi @Branikolog , then do you suggest to do? |
Hi, @Branikolog, are you talking about something like this? |
Hi, @Districh-ru !
Yes, this looks much better! The only issue I feel for your work is that water should have a little more smooth color transition near the plain part of the bank. |
Yeah, that was my original concept and we then switched to the beach. I agree that the cliffs are a slightly better fit as there's cliffs in the image already. Any chance you could pop into the Discord thread for us to go back to the drawing board with this? |
This is a quick copy-paste just to make a sketch for @golden-lining (using Paint.NET). :) It was made from a screenshot from PR topic without using game palette. |
close #1337
This is how it looks:
The animation of water is still based on the Shipyard image set so for now we use this.
All credits go to @golden-lining