Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bay for Wizard castle #7431

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add bay for Wizard castle #7431

wants to merge 5 commits into from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Jul 19, 2023

close #1337

This is how it looks:
image

The animation of water is still based on the Shipyard image set so for now we use this.

All credits go to @golden-lining

@ihhub ihhub added improvement New feature, request or improvement original assets Original game data related stuff labels Jul 19, 2023
@ihhub ihhub added this to the 1.0.7 milestone Jul 19, 2023
@ihhub ihhub self-assigned this Jul 19, 2023
@ihhub ihhub marked this pull request as draft July 19, 2023 15:12
@ihhub ihhub marked this pull request as ready for review August 10, 2023 13:37
@ihhub ihhub requested a review from oleg-derevenetz August 10, 2023 13:46
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ihhub, I left two code style related comments. Could you please check if theу make sense when you have time.

@golden-lining, well done!

src/fheroes2/castle/castle_building.cpp Outdated Show resolved Hide resolved
src/fheroes2/castle/castle_building.cpp Show resolved Hide resolved
@ihhub ihhub requested a review from Districh-ru August 11, 2023 14:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Branikolog
Copy link
Collaborator

Branikolog commented Aug 11, 2023

Hi, @ihhub !
I've tested the build and the new sprite seems to work fine.
The only concern I have is for the image itself. Besides the fact that the image has no animation in a shore part (which I suppose is not planned for now), this part lacks some details. Since there should be less water on the edge of the bay, so the ground should be more visible through water. I expect more smooth color transition on the coastline if the coastline is expected being so plain.
The castle territory is mostly rocky and we even see quite steep bank on the right side of the image, which could be continued for the whole visible part of the bay.

@ihhub
Copy link
Owner Author

ihhub commented Aug 12, 2023

Hi @Branikolog , then do you suggest to do?

@Districh-ru
Copy link
Collaborator

Hi, @Branikolog, are you talking about something like this?
изображение

@Branikolog
Copy link
Collaborator

Hi, @Districh-ru !

Hi, @Branikolog, are you talking about something like this? изображение

Yes, this looks much better! The only issue I feel for your work is that water should have a little more smooth color transition near the plain part of the bank.
As the water appears darker near rocky coastline (which you've continued pretty awesome), it could be a little brighter (or there could be added some brown pixels indicating a thinner water layer) near the plain part of the bank.

@golden-lining
Copy link

Yeah, that was my original concept and we then switched to the beach. I agree that the cliffs are a slightly better fit as there's cliffs in the image already. Any chance you could pop into the Discord thread for us to go back to the drawing board with this?

@Districh-ru
Copy link
Collaborator

Yes, this looks much better! The only issue I feel for your work is that water should have a little more smooth color transition near the plain part of the bank. As the water appears darker near rocky coastline (which you've continued pretty awesome), it could be a little brighter (or there could be added some brown pixels indicating a thinner water layer) near the plain part of the bank.

This is a quick copy-paste just to make a sketch for @golden-lining (using Paint.NET). :)
изображение

It was made from a screenshot from PR topic without using game palette.

@ihhub ihhub modified the milestones: 1.0.7, 1.0.8 Aug 14, 2023
@ihhub ihhub marked this pull request as draft August 23, 2023 04:18
@ihhub ihhub modified the milestones: 1.0.8, 1.0.9 Sep 11, 2023
@ihhub ihhub modified the milestones: 1.0.9, 1.1.0 Oct 11, 2023
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
@ihhub ihhub modified the milestones: 1.1.3, 1.1.4 Oct 23, 2024
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 27, 2024
@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement original assets Original game data related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual hint for Wizard castle with ocean access
6 participants