-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor chest dialog changes #9028
base: master
Are you sure you want to change the base?
Conversation
Introduce usage of getSpellDamage, thereby removing damage calculation and attacker artefact check.
Weird sha-256 dependency problem.
Update battle_troop.cpp
Update battle_troop.cpp
Update battle_troop.cpp
Hi @Cheerfulbull I suggest we limit the scope of this PR to #9025 and create a separate PR for #9024. The idea with the phrase "XP needed:" is questionable in general, because:
|
Alright, thank you, I updated the code and removed the text change, the updated PR description would then be:
|
If I understand correctly what the issue is, I suppose @LeHerosInconnu will say they're still not centered. With this PR: @LeHerosInconnu what do you think? |
Hello @Cheerfulbull and @oleg-derevenetz,
Effectively, you can see even with the naked eye that graphics and texts are not centered horizontally in relation to the respective buttons. :) |
Close #9025 and #9024 by centring the XP icon and text and changing the XP message to "XP Needed". One problem: the XP message, when centred, becomes very cramped (comes very close to the edge). What would be the best way to fix this?
Thank you.