Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German translations related to artifacts #9285

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felix-schneider
Copy link
Contributor

Notes:

  • (German) As per the discussion in Similar items share translation strings, which is inappropriate for languages with gendered nouns #9260, the definite article is now part of the artifact name.
    • (German) As part of this, normal grammar would demand that an adjective that is part of the artifact name would not be capitalized, as it is no longer at the start of the string (such as "Immervoller Erzkarren" vs. "Der Immervolle Erzkarren"). Looking at this in-game, this just looked weird to me, like it's just any old ever-full ore cart? It's THE ever-full ore cart! So I capitalized the adjectives as well. In cases of proper nouns, this is acceptable (c.f. the popular German TTRPG "Das Schwarze Auge").
  • (English) Pickup text for medal of Valor refers to "a" Medal of Valor (note capitalization). In other texts, when artifacts are reffered to by name, they are called "the" artifact.
    • Same for Medal of Courage and Medal of Honor, but not Medal of Distinction
  • (English) Ultimate Crown description refers to basic skills. Shoudn't they be called primary skills? (as opposed to the secondary skills) Basic skills could be confused with secondary skills at the basic level (so one could think the crown upgrades those to advanced)
    • Ultimate Scepter calls them attributes, which is also quite rare
  • (English) In the Medal of Distinction pickup text, the word "Knights" is capitalized. Is this meant to refer to heros of the Knight faction?
  • (English) The English artifact description usually refer to "the hero", whereas the German ones (in the OG also) refer to you directly.
  • (English) The Skullcap description refers to "all mind-influencing spells", whereas it should be "all mind-influencing spells you cast", it does not make your enemy's spells cheaper. Also, it's just a skullcap? Like that is an actual thing that exists. It doesn't have any adjective to make it magical, you're just wearing a Kippa?
  • (English) The Evil Eye has for some reason a different wording on its description than the Skullcap and the Snake-Ring. It says "reduced by half" and the others save "halves".
  • (German) I went with the shorter translation of spell as "Zauber" instead of the "Zauberspruch" from the OG. Especially when used as part of a compound, it leads to really long words. Until we have some kind of dynamic hyphenation, the long words do not render very nicely.
  • (German) While I'm not touching spells in this PR, the Wand of Negation mentions Dispel Magic. I never really like the translation of that spell as "Magie zerstreuen", which is really long, especially the mass version. I instead translated it as "Gegenzauber" - Counterspell. Side note: Even the translators of Magic the Gathering did not find an adequate equivalent of the word "dispel" in German. The Magic card "Dispel" is called "Bannzauber" - "Banish spell" in German.
  • (Both) The resource-generating artifacts have a replacement string for the amount, but they all say %{count} unit (singular), so if that amount ever changes, the string needs to be edited anyway, so why bother having it?
  • (English) The Staff of Wizardry says "boosts your spell power" whereas all other artifacts say "increases your spell power"
  • (German) German does not use the same quotation marks as English. In English, you use upper quotation marks (\u0022 or more correctly \u201C and \u201D) at the start and end of a direct quote. In German, at the start of a quotation, you would use the "low double comma" \u201E at the start and upper double quotes \u201C at the end. Both of those can be represented in CP1252 (0x84 and 0x93, respectively), but sadly it looks like the in-game font has no glyphs for them. The OG seems to actually use single quotes (actually apostrophes, \u0027) in some cases (e.g. the spell scroll). I have not followed this example and used \u0022 instead.

@ihhub ihhub added improvement New feature, request or improvement translation Things related to languages and translations labels Nov 19, 2024
@ihhub ihhub added this to the 1.1.4 milestone Nov 19, 2024
@ihhub ihhub requested review from zenseii and ihhub November 20, 2024 11:52
@felix-schneider
Copy link
Contributor Author

After further discussion on discord, I decided to go back and compare the translations more closely against the original game. Please don't merge this yet.

@ihhub
Copy link
Owner

ihhub commented Nov 21, 2024

Hi @felix-schneider , in the future if you would like to prevent a pull request being merged you can use Convert to draft option which does this and also indicates that the pull request needs some work.

Once all work is done you can use the Ready to review button.

@ihhub ihhub marked this pull request as draft November 21, 2024 09:57
@ihhub ihhub modified the milestones: 1.1.4, 1.1.5 Nov 24, 2024
"Mitleid und willigt ein, lebenslang nur 250 Gold pro Tag von Eurem Konto "
"abzuziehen. Unterschreibt hier, wenn Ihr für den Wahlkampffonds des "
"Praesidenten spenden wollt."
"Eure überschwängliches Prasserei hat Euch eine Steuerrechnung eingebracht, "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*überschwängliche


msgid ""
"You've found the humble dwelling of a withered hermit. The hermit tells you "
"that he is willing to give the %{art} to the first wise person he meets."
msgstr ""
"Ihr habt die bescheidene Behausung eines vertrockneten Einsiedlers gefunden. "
"Der Einsiedler erzählt Euch, dass er bereit ist, die %{art} dem ersten "
"weisen Menschen zu geben, den er trifft."
"Der Einsiedler erzählt Euch, dass er im Besitz eines Artefakts ist, dass er "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Der Einsiedler erzählt Euch, er ist im Besitz eines Artefakts, von dem er bereit ist, es dem ersten weisen Menschen zu geben, den er trifft:"


msgid ""
"You've come across the spartan quarters of a retired soldier. The soldier "
"tells you that he is willing to pass on the %{art} to the first true leader "
"he meets."
msgstr ""
"Ihr seid auf das spartanische Quartier eines pensionierten Soldaten "
"gestoßen. Der Soldat erzählt Euch, dass er bereit ist, die %{art} an den "
"ersten wahren Anführer weiterzugeben, den er trifft."
"gestoßen. Der Soldat erzählt Euch, dass er im Besitz eines Artefakts ist, "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Der Soldat erzählt Euch, er ist im Besitz eines Artefakts, von dem er bereit ist, es an den ersten wahren Anführer weiterzugeben, den er trifft"

@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants