Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit all resolutions on MacOS to currently selected resolution in the system #9323

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Dec 7, 2024

We need to be careful while limiting resolutions on user's machines. At the moment resolution limited being tested on MacOS only.

close #9273

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff macOS macOS labels Dec 7, 2024
@ihhub ihhub added this to the 1.1.5 milestone Dec 7, 2024
@ihhub ihhub self-assigned this Dec 7, 2024
Copy link

sonarqubecloud bot commented Dec 7, 2024

@ihhub ihhub requested a review from oleg-derevenetz December 7, 2024 05:43
Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihhub IMHO, in a good way, it would be worth to get the resolution info about the display where the fheroes2 is currently running (using the SDL_GetWindowDisplayIndex()) and not just the first display (although of course I'm not sure about this, because the user can drag the game between the displays). Regarding macOS, what do you think about choosing the "minimum max resolution" among all displays (but maybe the one that is still not less than 640x480?) and using it as an upper bound? After all, the user can drag the game between the displays, can this lead to switching the display mode on macOS?

@ihhub ihhub marked this pull request as draft December 8, 2024 01:44
@ihhub
Copy link
Owner Author

ihhub commented Dec 8, 2024

Hi @oleg-derevenetz , these are very good points. I will update the code based on your comment

@ihhub ihhub modified the milestones: 1.1.5, 1.1.6 Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement macOS macOS ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game resolution on MacOS is a complete mess
2 participants