-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swap army and swap artifacts to the heroes meeting screen #9387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Hi, @zenseii |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zenseii I added an assertion to verify that hero will not get an empty army due to army exchange and also modernized some army-related code (while I'm here).
Thanks, @oleg-derevenetz! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, @zenseii!
I have one suggestion that can be addressed in a new PR:
We should add the right-click info to help players fully understand the mechanics of all arrow-buttons in this dialog.
Thanks, @Districh-ru! Yes, this is a good suggestion. We can make such a PR after this one. |
@zenseii , huge thanks for implementing this! |
This PR adds the swap army button and swap artifacts features to the heroes meeting screen.
Relates to #4084
Button design by @FlorianBaba and me.
Swap artifacts was added to make the screen design more consistent and it has been requested by the community according to @Branikolog.
Rotation of the arrow parts was done with this ( sin270 = -1 and cos270 = 0): https://en.m.wikipedia.org/wiki/Rotation_matrix