Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few recently introduced code smells #9412

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

oleg-derevenetz
Copy link
Collaborator

@oleg-derevenetz oleg-derevenetz commented Jan 5, 2025

  • Don't create an empty anonymous namespace for non-Emscripten builds (code smell from SonarCloud);
  • Limit the scope of the disabled Emscripten-specific -Wvariadic-macro-arguments-omitted warning.

@oleg-derevenetz oleg-derevenetz added the improvement New feature, request or improvement label Jan 5, 2025
@oleg-derevenetz oleg-derevenetz added this to the 1.1.6 milestone Jan 5, 2025
@oleg-derevenetz oleg-derevenetz marked this pull request as ready for review January 5, 2025 13:08
@oleg-derevenetz oleg-derevenetz requested a review from ihhub January 5, 2025 13:08
@ihhub ihhub merged commit ee5bdfb into ihhub:master Jan 5, 2025
22 checks passed
@ihhub
Copy link
Owner

ihhub commented Jan 5, 2025

@oleg-derevenetz , thank you so much for this cleanup!

@oleg-derevenetz oleg-derevenetz deleted the code-smell-fix branch January 5, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants