Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version for tutorials #898

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Dec 9, 2024

We're seeing the same error in our CI again as we did previously when GitHub runner-images first changed ubuntu-latest to Ubuntu 24.04. They are rolling out the same change again now. However, we have adopted Python 3.13 in the meantime and in the ixmp test suite, this seems to work, while Python 3.12 produces the same error with Ubuntu 24.04. 3.11 works with that image, too, so the error might be specific to Python 3.12. Thus, this PR bumps the Python version we use for the tutorial tests in hopes of enabling them to run again on ubuntu-latest.

If this works, we might be able to adjust the ixmp test suite to only use Ubuntu 22.04 with Python 3.12.

See IRkernel/IRkernel#747 and r-lib/actions#932 for the issues I opened about this back then.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update test suite; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI bump.
  • [ ] Update release notes. Just CI bump.

@glatterf42 glatterf42 added the ci Continuous integration label Dec 9, 2024
@glatterf42 glatterf42 self-assigned this Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.6%. Comparing base (5c0b44f) to head (9829ee6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #898   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         46      46           
  Lines       4337    4338    +1     
=====================================
+ Hits        4147    4148    +1     
  Misses       190     190           
Files with missing lines Coverage Δ
message_ix/tests/test_report.py 100.0% <100.0%> (ø)

@glatterf42
Copy link
Member Author

All tutorial tests are now failing, but notably after the step that is failing in our CI suite. This seems to confirm that using Python 3.13 with Ubuntu 24.04 resolves that issue :)

The reason the tests are still failing is likely that pyam doesn't officially support Python 3.13 yet, which it can't until ixmp4 does. For ixmp4, all that is needed for that is a new release, which I will ask about right away. I even prepared a PR for pyam already.

@glatterf42
Copy link
Member Author

I have now also opened actions/runner-images#11137 to see if this bug can be resolved on the runner-image level.

@glatterf42
Copy link
Member Author

As expected: with the release of pyam 3.0.0, which supports Python 3.13, the tutorial tests are passing again (using Python 3.13 for all OSs). Support for Pyam 3.13 requires a small adaptation in our test suite, which this PR also provides now.

@glatterf42 glatterf42 requested a review from khaeru December 20, 2024 07:07
@glatterf42 glatterf42 force-pushed the fix/ubuntu-tutorials-r-jupyter branch from 1c70a9a to 1a5a066 Compare December 20, 2024 07:15
Copy link
Contributor

@measrainsey measrainsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @glatterf42 ! :)

@glatterf42 glatterf42 merged commit ab9b707 into main Dec 20, 2024
27 checks passed
@glatterf42 glatterf42 deleted the fix/ubuntu-tutorials-r-jupyter branch December 20, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants