-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Python version for tutorials #898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 46 46
Lines 4337 4338 +1
=====================================
+ Hits 4147 4148 +1
Misses 190 190
|
All tutorial tests are now failing, but notably after the step that is failing in our CI suite. This seems to confirm that using Python 3.13 with Ubuntu 24.04 resolves that issue :) The reason the tests are still failing is likely that pyam doesn't officially support Python 3.13 yet, which it can't until ixmp4 does. For ixmp4, all that is needed for that is a new release, which I will ask about right away. I even prepared a PR for pyam already. |
I have now also opened actions/runner-images#11137 to see if this bug can be resolved on the runner-image level. |
As expected: with the release of pyam 3.0.0, which supports Python 3.13, the tutorial tests are passing again (using Python 3.13 for all OSs). Support for Pyam 3.13 requires a small adaptation in our test suite, which this PR also provides now. |
1c70a9a
to
1a5a066
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @glatterf42 ! :)
We're seeing the same error in our CI again as we did previously when GitHub runner-images first changed
ubuntu-latest
to Ubuntu 24.04. They are rolling out the same change again now. However, we have adopted Python 3.13 in the meantime and in the ixmp test suite, this seems to work, while Python 3.12 produces the same error with Ubuntu 24.04. 3.11 works with that image, too, so the error might be specific to Python 3.12. Thus, this PR bumps the Python version we use for the tutorial tests in hopes of enabling them to run again onubuntu-latest
.If this works, we might be able to adjust the ixmp test suite to only use Ubuntu 22.04 with Python 3.12.
See IRkernel/IRkernel#747 and r-lib/actions#932 for the issues I opened about this back then.
How to review
PR checklist
[ ] Add, expand, or update documentation.Just CI bump.[ ] Update release notes.Just CI bump.