Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add : General Settings School #125

Merged
merged 15 commits into from
Jul 27, 2024
Merged

Conversation

reactmore
Copy link
Contributor

@reactmore reactmore commented Jul 24, 2024

Pull Request

Deskripsi

Membuat pengaturan sekolah untuk mengganti logo, nama, tahun ajaran nantinya bisa ada value lain, variable ini di include dalam baseController dan baseModel jadi tidak perlu memanggilnya berulang.

Untuk Pemanggilan di views :

$generalSettings->school_name

Untuk penggunaan di controller atau model yang extend dari baseModel:

$this->generalSettings->school_name 

Saya juga menambahkan beberapa helper untuk validate, Post, dan Get yang aman di Common.php

// Fungsinya sama seperti request posts tapi sudah di tambahkan filter trim dan remove forbiden character untuk keamanan
inputPost($input_name, $removeForbidden = false)  

Checklist

Pastikan semua item berikut telah Anda periksa sebelum mengirimkan permintaan pull:

  • Perubahan telah diuji dan berfungsi dengan baik.
  • Dokumentasi telah diperbarui sesuai dengan perubahan.
  • Tidak ada konflik merge dengan cabang utama.

Catatan Tambahan

@reactmore reactmore marked this pull request as ready for review July 24, 2024 13:14
@reactmore reactmore marked this pull request as draft July 24, 2024 13:29
@reactmore
Copy link
Contributor Author

Baru nyadar jurusan dan kelas controllernya pake resourceController

@reactmore reactmore marked this pull request as ready for review July 24, 2024 13:35
@ikhsan3adi ikhsan3adi self-requested a review July 24, 2024 13:46
Copy link
Owner

@ikhsan3adi ikhsan3adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mantap, LGTM!

@ikhsan3adi ikhsan3adi added the enhancement New feature or request label Jul 24, 2024
@ikhsan3adi
Copy link
Owner

Saya coba dulu, tinggal dokumentasi di readme-nya perlu diubah

@reactmore
Copy link
Contributor Author

sudah di update Readme dan remove config lama nya mas

@ikhsan3adi ikhsan3adi self-assigned this Jul 27, 2024
@ikhsan3adi ikhsan3adi merged commit 59ba924 into ikhsan3adi:master Jul 27, 2024
1 check passed
@reactmore reactmore deleted the development branch July 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants