-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add : General Settings School #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baru nyadar jurusan dan kelas controllernya pake resourceController |
ikhsan3adi
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mantap, LGTM!
Saya coba dulu, tinggal dokumentasi di readme-nya perlu diubah |
sudah di update Readme dan remove config lama nya mas |
ikhsan3adi
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Deskripsi
Membuat pengaturan sekolah untuk mengganti logo, nama, tahun ajaran nantinya bisa ada value lain, variable ini di include dalam baseController dan baseModel jadi tidak perlu memanggilnya berulang.
Untuk Pemanggilan di views :
Untuk penggunaan di controller atau model yang extend dari baseModel:
Saya juga menambahkan beberapa helper untuk validate, Post, dan Get yang aman di Common.php
Checklist
Pastikan semua item berikut telah Anda periksa sebelum mengirimkan permintaan pull:
Catatan Tambahan