fix: ID-2791 Fix zero nonce issue for ejection transactions (#2373)

immutable · Nov 7, 2024 · 26387ba · 26387ba
1 parent b09cd73
commit 26387ba
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/packages/passport/sdk/src/mocks/zkEvm/msw.ts b/packages/passport/sdk/src/mocks/zkEvm/msw.ts
@@ -10,6 +10,7 @@ export const relayerId = '0x745';
 export const transactionHash = '0x867';
 
 const mandatoryHandlers = [
+  rest.get('https://api.sandbox.immutable.com/v1/sdk/session-activity/check', async (req, res, ctx) => res(ctx.status(404))),
   rest.post('https://rpc.testnet.immutable.com', async (req, res, ctx) => {
     const body = await req.json<JsonRpcRequestPayload>();
     switch (body.method) {

diff --git a/packages/passport/sdk/src/zkEvm/transactionHelpers.test.ts b/packages/passport/sdk/src/zkEvm/transactionHelpers.test.ts
@@ -286,5 +286,28 @@ describe('transactionHelpers', () => {
         flow,
       })).rejects.toThrow('Transaction send failed');
     });
+
+    describe('when the nonce is 0', () => {
+      it('prepares and signs transaction correctly', async () => {
+        const result = await prepareAndSignTransaction({
+          transactionRequest: {
+            ...transactionRequest,
+            nonce: 0,
+          },
+          ethSigner,
+          rpcProvider,
+          guardianClient,
+          relayerClient,
+          zkEvmAddress,
+          flow,
+        });
+
+        expect(result).toEqual({
+          signedTransactions,
+          relayerId,
+          nonce,
+        });
+      });
+    });
   });
 });
diff --git a/packages/passport/sdk/src/zkEvm/transactionHelpers.ts b/packages/passport/sdk/src/zkEvm/transactionHelpers.ts
@@ -230,7 +230,7 @@ const buildMetaTransactionForEjection = async (
     );
   }
 
-  if (!transactionRequest.nonce) {
+  if (typeof transactionRequest.nonce === 'undefined') {
     throw new JsonRpcError(
       RpcErrorCode.INVALID_PARAMS,
       'im_signEjectionTransaction requires a "nonce" field',