Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add py.typed to the package definition #667

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 2, 2024

Closes #666

Proposed Changes

Fixed adding py.typed into package.

Tested via:

mkdir typed
cd typed
python -m venv venv
. venv/bin/activate
python -m pip install git+https://github.com/influxdata/influxdb-client-python.git@typed-definition-setup.py
ls -l venv/lib/python3.11/site-packages/influxdb_client

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (7ad9533) to head (c01fb0e).
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #667   +/-   ##
=======================================
  Coverage   90.47%   90.47%           
=======================================
  Files          40       40           
  Lines        3526     3526           
=======================================
  Hits         3190     3190           
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar marked this pull request as ready for review September 2, 2024 10:02
@bednar bednar added this to the 1.46.0 milestone Sep 2, 2024
@bednar bednar merged commit 63949b5 into master Sep 2, 2024
21 checks passed
@bednar bednar deleted the typed-definition-setup.py branch September 2, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hints (py.typed) missing from pypi release
3 participants