-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: async write prec where DEFAULT_PRECISION should not be used #675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 90.47% 90.49% +0.01%
==========================================
Files 40 40
Lines 3528 3534 +6
==========================================
+ Hits 3192 3198 +6
Misses 336 336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Closes #669
Proposed Changes
precision_from_point
in internal_serialize
method toTrue
.WritePrecision
key in resulting payloadprecision
argument in call to internal_write_service.post_write_async
test_write_points_different_precision
to cover more current possible valuesChecklist
pytest tests
completes successfully