-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the best traces as we go using insertion sort instead of sorting the whole array each time #1481
Conversation
Here is a benchmark to compare the two approaches. It looks like even with only 1k elements and a super cheap comparison function on integers this makes quite the difference: |
@bugarela Let me know if you want to move forward with this, and I will add a changelog entry. Otherwise, no problem :) |
I absolutely do! I haven't reviewed it since it is marked as a draft, but I can do it. Thank you for doing this! |
Ok great, I'll let you take care of the changelog then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much to taking care of this in such organization ✨
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
See this thread for background information: #1465 (comment)
This might be completely overkill if
n-traces
is in practice less than a few thousands, but it was fun to write :) No worries if you'd rather not merge it because of that.CHANGELOG.md
for any new functionalityREADME.md
updated for any listed functionality