Simplify only new types to improve performance on incremental analysis #1483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This is a simple performance improvement for the REPL (which uses incremental analysis). Instead of iterating over all types each time inference is called, we use set difference and only iterate over new ids.
No behavior should change (other than performance)
@josef-widder has a large spec that is causing the REPL to be quite slow. This improves that, but I have one more meaningful change cooking. See benchmarks to loading + evaluating a single expression in his project:
Before this fix:
After this fix:
CHANGELOG.md
for any new functionalityREADME.md
updated for any listed functionality