Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format of ITF trace emitted by verify command #1491

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Fix format of ITF trace emitted by verify command #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fe8cce
Fix format of ITF trace emitted by `verify` command
romac Aug 30, 2024
51758e1
Add changelog entry
romac Aug 30, 2024
4b59615
Fix Apalache test
romac Aug 30, 2024
44a66d2
Merge branch 'main' into romac/fix-verify-itf-format
romac Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Bumped GRPC message sizes to 1G (#1480)
- Bumped GRPC message sizes to 1G (#1480)
- Fix format of ITF trace emitted by `verify` command (#1448)

### Security

Expand Down
2 changes: 1 addition & 1 deletion quint/apalache-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ An example execution:
<!-- !test in writes an ITF trace to file -->
```
quint verify --out-itf violateOnFive.itf.json --invariant inv ./testFixture/apalache/violateOnFive.qnt
jq '.[0]."#meta".format' violateOnFive.itf.json
jq '."#meta".format' violateOnFive.itf.json
rm ./violateOnFive.itf.json
```

Expand Down
4 changes: 2 additions & 2 deletions quint/src/cliCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,8 +805,8 @@ export async function verifySpec(prev: CompiledStage): Promise<CLIProcedure<Trac
console.log(chalk.red(`[${status}]`) + ' Found an issue ' + chalk.gray(`(${elapsedMs}ms).`))
}

if (prev.args.outItf) {
writeToJson(prev.args.outItf, err.traces)
if (prev.args.outItf && err.traces) {
writeToJson(prev.args.outItf, err.traces[0])
}
}
return {
Expand Down
Loading