Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin: Expect separate profiles for CN region #469

Merged
merged 1 commit into from
Nov 7, 2023
Merged

bin: Expect separate profiles for CN region #469

merged 1 commit into from
Nov 7, 2023

Conversation

Ferenc-
Copy link
Collaborator

@Ferenc- Ferenc- commented Nov 6, 2023

No description provided.

@Ferenc-
bin: Expect separate profiles for CN region
4cd03a6 
Signed-off-by: Ferenc Géczi <ferenc.geczi@ibm.com>
@Ferenc- Ferenc- requested review from pvital and GSVarsha November 6, 2023 17:58
pvital
pvital previously requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an extra change request. But it looks good.

bin/aws-lambda/build_and_publish_lambda_layer.py Show resolved Hide resolved
@Ferenc- Ferenc- dismissed pvital’s stale review November 7, 2023 15:12

Opened separate PR for that #470

@Ferenc- Ferenc- merged commit d05cbe1 into master Nov 7, 2023
2 checks passed
@Ferenc- Ferenc- deleted the separate-cn-profile branch November 7, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital left review comments

@GSVarsha GSVarsha Awaiting requested review from GSVarsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferenc- @pvital