Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from kubebuilder v3.12.0 to v3.13.0 #1123

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

int128
Copy link
Owner

@int128 int128 commented Aug 15, 2024

Copy link
Contributor

diff

  • config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
  • e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml

config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXX8qa0d0/config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXaUwA5s/config/default/apps_v1_deployment_argocd-commenter-controller-manager.yaml
@@ -23,6 +23,23 @@ spec:
     spec:
       containers:
       - args:
+        - --secure-listen-address=0.0.0.0:8443
+        - --upstream=http://127.0.0.1:8080/
+        - --logtostderr=true
+        - --v=10
+        image: gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0
+        name: kube-rbac-proxy
+        ports:
+        - containerPort: 8443
+          name: https
+        securityContext:
+          allowPrivilegeEscalation: false
+          capabilities:
+            drop:
+            - ALL
+      - args:
+        - --health-probe-bind-address=:8081
+        - --metrics-bind-address=127.0.0.1:8080
         - --leader-elect
         command:
         - /manager
@@ -79,6 +96,9 @@ spec:
             memory: 128Mi
         securityContext:
           allowPrivilegeEscalation: false
+          capabilities:
+            drop:
+            - ALL
       securityContext:
         runAsNonRoot: true
       serviceAccountName: argocd-commenter-controller-manager

e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml

--- a/tmp/kustomize-action-XXXXXX8qa0d0/e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml
+++ b/tmp/kustomize-action-XXXXXXaUwA5s/e2e_test/controller/apps_v1_deployment_argocd-commenter-controller-manager.yaml
@@ -23,6 +23,23 @@ spec:
     spec:
       containers:
       - args:
+        - --secure-listen-address=0.0.0.0:8443
+        - --upstream=http://127.0.0.1:8080/
+        - --logtostderr=true
+        - --v=10
+        image: gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0
+        name: kube-rbac-proxy
+        ports:
+        - containerPort: 8443
+          name: https
+        securityContext:
+          allowPrivilegeEscalation: false
+          capabilities:
+            drop:
+            - ALL
+      - args:
+        - --health-probe-bind-address=:8081
+        - --metrics-bind-address=127.0.0.1:8080
         - --leader-elect
         command:
         - /manager
@@ -79,6 +96,9 @@ spec:
             memory: 128Mi
         securityContext:
           allowPrivilegeEscalation: false
+          capabilities:
+            drop:
+            - ALL
       securityContext:
         runAsNonRoot: true
       serviceAccountName: argocd-commenter-controller-manager

See the workflow run

@int128 int128 merged commit 416d4f7 into main Aug 15, 2024
5 checks passed
@int128 int128 deleted the upgrade-kubebuilder-v3.13.0 branch August 15, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant