Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Dockerfiles to Go v1.22.5 and update imgconv to generate viewable images in web from tiff #104

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

seanohair22
Copy link
Contributor

@seanohair22 seanohair22 commented Jul 8, 2024

PR Checklist

Author Mandatory (to be filled by PR Author/Submitter)

CODE MAINTAINABILITY

  • Commit Message meets guidelines as indicated in the URL*
  • Tests for the changes have been added (required for bug fixes / features). If not, state why not
  • Added labels (these are git labels such as bug or enhancement)
  • For any API changes or service changes, updates to the documentation were made (Swagger APIs & GitHub Docs). If not, state why not
  • Every commit is a single defect fix and does not mix feature addition or changes*

What are the steps to test this PR contribution?

How does a reviewer know it works?

  • Make sure you have at least Go v1.22.5 or better installed
  • Run make docker to build new containers
  • Run make run-sim
  • Open localhost:4200 and create a task to process tiff files
  • Open View Files tab once a job is processed and see that the input and output files are viewable in the web-ui
  • Run make clean-files to clean the directory structure
  • Run make integration-test

Are there any special instructions beyond standard workflow?

Maintainer Mandatory (to be filled by PR Reviewer/Approving Maintainer)

QUALITY CHECKS

  • Quality of code (At least one should be checked as applicable)*
    • Commit Message meets guidelines
    • Code copyright is correct
    • PR changes adhere to industry practices and standards as well as domain or language specific anti-patterns
    • Adopted domain specific coding standards (Go Coding Standards)
    • Code is adequately commented and documented
    • Confusing logic is explained in comments
    • Error and exception code paths implemented correctly
    • Tracing output are minimized and logic
  • Test coverage shows adequate coverage with required CI functional tests pass on all supported platforms*
  • Static code scan report shows zero critical issues*

Other information

Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
@seanohair22 seanohair22 added the dependencies Pull requests that update a dependency file label Jul 8, 2024
@seanohair22 seanohair22 self-assigned this Jul 8, 2024
@seanohair22 seanohair22 requested a review from a team as a code owner July 8, 2024 22:45
Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Copy link
Contributor

@NeethuES-intel NeethuES-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. everything worked.

@seanohair22 seanohair22 merged commit 14d7dcd into intel:main Jul 9, 2024
5 of 6 checks passed
antoniomtz added a commit that referenced this pull request Aug 6, 2024
* Fix: Update Dockerfiles to Go v1.22.5 and update imgconv to generate viewable images in web from tiff (#104)

* fix: update imgconv to use latest version which resolves dep issue

* fix: imgconv and update go to v1.22.5

* fix: update test github action to use go v1.22.5
---------

Signed-off-by: Sean O'Hair <sean.ohair@intel.com>

* Adding EVAM compose-file

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* removing build section

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* progress on EVAM integration

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* Progress on EVAM calls

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* Implemented file and inference output

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* Cleaning code

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* clean up and small changes

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* addressing PR review

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

* Adding geti container to support upload models through UI

Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>

---------

Signed-off-by: Sean O'Hair <sean.ohair@intel.com>
Signed-off-by: Antonio Martinez <jose.antonio.martinez.torres@intel.com>
Co-authored-by: seanohair22 <sean.ohair@intel.com>
@seanohair22 seanohair22 deleted the imgconv_fix_dep branch January 2, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants