Make intrinsics module searching more robust #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMEntry attribute now is passing through CM Adaptor and is converted to VCFCEntry
Add gitignore. Update licences.
Added new GenXVersion.h file that contains up-to-date commit hash and repository url that sources came from.
Replacing usage of cmake variable not defined if built in-tree
Fix problem causing git version not being collected
Fix version retrive fail when building from GenXIntrinsics directory directly
Move add_definitions and include_directories to intrinsics CMake from other places.
Use getNameNoUnnamedTypes for LLVM tot to avoid buildbreak.
Now every intrinsic has list of suported platforms.
write_predef_surface is main intrinsic to initialize %bss. Other intrinsics are duplicates of original intrinsics with ability to work with %bss variable.
update Python copyright to PEP8 style
Fix intrinsics build after https://reviews.llvm.org/rG92ce6db9ee7666a347fccf0f72ba3225b199d6d1
SPIRVAdaptor passes didn't properly handle the pointer attributes when rewiting types in kernel signature leading to module verification failure
VC always uses simd1 mode with separate intrinsics.
Remove unused wrapper to fix buildfail because of attribute removal API change. New class was added in D116110 and wrapping of this case is not trivial so removal of unneeded function is the easiest solution.
Fix an issue where GenXIntrinsicDescription.gen is included without including map header.
dyn_extract implies that nullptr can be returned, while in this case we need a more strict check.
Set some tests to XFAIL on latest LLVM 15
GenXSingleElementVectorUtil did not forward metadata and attributes for call instructions with SEV. This commit fixes it.
Add add3 with carry intrinsic
Remove XFAIL from some tests
named barrier required for DPC++ and other customers
PointerType::getElementType() was removed from LLVM. https://reviews.llvm.org/rGd593cf79458a59d37e75c886a4fc3ac6a02b484d
Use VCIntrinsics<LLVMVersion> naming scheme for exported package to solve two issues: 1. Exported package does not have LLVM prefix to express that this is not LLVM project code. 2. Exported package has explicit LLVM version in name so potential errors with LLVM versions mismatch can be caught earlier. Old LLVMGenXIntrinsics export is left for backward compatibility. It will be removed later.
This was a source of build errors at least once.
Unify handling of intrinsics interface includes in both modes.
* add one missing caching behavior (.ca) * separate caching documentation for loads and stores
Fill debug values in created instructions
add PVCXT_A0 platform and refactor the list initialization to simplify maintenance
Add some functions to get LSC special argument indices. Add function to get encoded LSCVectorSize.
External intrinsics order is expected to be unchanged to keep SPIR-V compatibility.
Build might fail because of `-Werror -Wcovered-switch-default` options passed to gcc and clang
Correctly handle LSC 2d stateless intrinsics
IGC build used to fail because of warnings/errors emitted by gcc
Toolchain build used to fail when LLVM_LINK_LLVM_DYLIB is enabled
Portable(or embedded) versions of python doesn't have the script directory in the module search path by default. So, adding expected module directory in the script itself allows the script to work correctly even with such versions of python.
|
@vmustya FYI |
AlexeySachkov
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portable(or embedded) versions of python don't have the script
directory in the module search path by default. So, adding the
expected module directory in the script itself allows the script
work correctly even with such versions of python.