Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style #60

Closed
wants to merge 1 commit into from
Closed

Update code style #60

wants to merge 1 commit into from

Conversation

dankimio
Copy link
Contributor

@dankimio dankimio commented Nov 3, 2019

I've used the default style guide from RuboCop.

This sets foundation for further changes from #56.

Changes

  • Removed Ruby 2.3 safe navigation syntax

@danrabinowitz
Copy link
Collaborator

This is a good start. Two things we'd need to proceed with this are:

  1. Include the gem as a "development_dependency" in the gemspec, and
  2. Include a new .rubocop.yml file, even if it's mostly empty.

These are needed to ensure consistency, so that everyone on the project uses the same version of the gem, and the same rubocop rules.

@dankimio dankimio closed this Nov 4, 2019
@dankimio dankimio deleted the code-style branch December 22, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants