Enable PLR5501 - Convert nested if statements to elif clauses for better readability #10260
+36
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
approved these changes
Jan 3, 2025
RayBB
added
the
Needs: Staff / Internal
24 tasks
RayBB
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10196
Changed made automatically by ruff (only using safe mode, not --unsafe)
This pull request addresses PLR5501 by simplifying conditional statements across the codebase. Specifically, it replaces instances of else followed by if with elif, enhancing both readability and structure.
Technical Details
Testing
Linting has been successfully completed with no errors (PLR5501 resolved).
Screenshot
Stakeholders
@RayBB
Let me know if you need any further adjustments!